Repository navigation
fix(publish): approve the v20.1.6 publisher for organization settings - #5900
Merged
Merged
Conversation
Accept devantler-tech/.github publish-manifests at v20.1.6 (56ceec67) for the github-config source, keep v20.0.3 (57310dc6) that signed the release served today, and retire v19.0.8 (0966f4b0). The publisher's workflow blob matches v20.1.4; both helper scripts are unchanged. Fixes #5872 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devantler
commented
Nov 7, 2026
devantler
left a comment
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: 5edb078fdee5b6f0299c5f39ccc5cf0cc26c0812
- CodeRabbit: rate limited (portfolio rate-limit refusal 2026-11-07T13:25Z; no review delivered since).
- Codex: usage limit reached since 2026-11-04T19:23Z (maintainer-only to lift).
- Cursor Bugbot: usage limit reached since 2026-11-07T12:01Z (maintainer-only to lift).
Checked:
- The admitted pair is now 57310dc6 (v20.0.3, which signed the release
.githubserves today; itscd.yamlstill pins it) and 56ceec67 (v20.1.6, the commit .github#877 pins). The approvals table and the source subject regex name exactly that pair, in both places. - The published workflow differs between 57310dc6 and 56ceec67 by one line only: the harden-runner pin moves from v2.22.2 to v2.22.3. Both helper-script blobs are unchanged, so nothing that signs, pushes or chooses what is published changes.
- Retiring 0966f4b0 (v19.0.8) is safe: nothing running was published by it. The identity fixtures now reject it, and they reject the old bd24a3e1 too.
- The negative identity fixtures (wrong issuer, look-alike issuer, other org, look-alike repo, wrong workflow, short SHA, suffix) now run against an approved commit, so each one proves only its own mutation.
- The approved-surface ledger changes only the github-config OCIRepository line. That matches the single rendered object this PR changes. The validator passed locally with the pinned renderer, and CI is green.
Verdict: no P0/P1 findings
Contributor
Author
Readiness at
Entering the merge queue. |
devantler
marked this pull request as ready for review
November 7, 2026 16:08
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A pending dependency update moves the organization settings publisher to a newer version. The platform only accepts settings releases signed by publisher versions it has approved, so the next settings release would be refused in production until this approval is deployed.
What
Approve the newer publisher alongside the one that signed the settings release running today, and retire an older approval that nothing running still depends on. The only change in the publisher between the approved version and the new one is a newer pinned runner-hardening tool.
Fixes #5872